Yeet mir::Const::from_anon_const
#116446
Merged
Yeet mir::Const::from_anon_const
#116446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
b-naber
reviewed
Oct 12, 2023
| @@ -647,15 +647,35 @@ impl<'tcx> Cx<'tcx> { | |||
| out_expr: out_expr.map(|expr| self.mirror_expr(expr)), | |||
| }, | |||
| hir::InlineAsmOperand::Const { ref anon_const } => { | |||
| let value = | |||
| mir::Const::from_anon_const(tcx, anon_const.def_id, self.param_env); | |||
| let value = mir::Const::Unevaluated( | |||
There was a problem hiding this comment.
This code is duplicated below. Maybe put this in a function?
|
☔ The latest upstream changes (presumably #117405) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot ready |
rust-cloud-vms
bot
force-pushed
the
yeet-mir-from_anon_const
branch
from
ee4cfe8 to
6de5ea5
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Nov 18, 2023
…_const, r=b-naber Yeet `mir::Const::from_anon_const` Only had one callsite which was easily simplified. Uplifted a comment that I think is much more useful living in `ty::Const` world.
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Nov 18, 2023
…_const, r=b-naber Yeet `mir::Const::from_anon_const` Only had one callsite which was easily simplified. Uplifted a comment that I think is much more useful living in `ty::Const` world.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#116446 (Yeet `mir::Const::from_anon_const`) - rust-lang#116750 (Add Seek::seek_relative) - rust-lang#117110 (Suggest field typo through derefs) - rust-lang#117961 (Add `x suggest` entries for testing `mir-opt` and `coverage`) - rust-lang#118020 (Fix links to `From<{OwnedHandle, OwnedFd}> for std::process::Child{Stdin, Stdout, Stderr}` in 1.74 release notes) - rust-lang#118034 (bump few deps to fix unsoundness and drop few dup deps) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors r- |
bors
added
S-waiting-on-author
|
This pull request caused an error here. |
compiler-errors
force-pushed
the
yeet-mir-from_anon_const
branch
from
6de5ea5 to
8bf9c18
Compare
|
Limited test to just x86_64 for asm support @bors r=b-naber |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 25, 2023
…_const, r=b-naber Yeet `mir::Const::from_anon_const` Only had one callsite which was easily simplified. Uplifted a comment that I think is much more useful living in `ty::Const` world.
This was referenced Nov 25, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#116446 (Yeet `mir::Const::from_anon_const`) - rust-lang#117871 (remove unused pub fns) - rust-lang#118017 (rustc_lint: address latent TODO) - rust-lang#118199 (Remove `HirId` from `QPath::LangItem`) - rust-lang#118272 (resolve: Avoid clones of `MacroData`) - rust-lang#118291 (rustdoc-search: clean up some DOM code) Failed merges: - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups) - rust-lang#118256 (rustc: `hir().local_def_id_to_hir_id()` -> `tcx.local_def_id_to_hir_id()` cleanup) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2023
Rollup merge of rust-lang#116446 - compiler-errors:yeet-mir-from_anon_const, r=b-naber Yeet `mir::Const::from_anon_const` Only had one callsite which was easily simplified. Uplifted a comment that I think is much more useful living in `ty::Const` world.
RalfJung
reviewed
Sep 28, 2024
| /// Literals are converted to `Const::Val`, const generic parameters are eagerly | ||
| /// converted to a constant, everything else becomes `Unevaluated`. | ||
| #[instrument(skip(tcx), level = "debug", ret)] | ||
| pub fn from_anon_const( |
There was a problem hiding this comment.
Thank you so much for removing this... I never had any clue what it really does, it was such a complicated mess, but it's all sorts of stuff I didn't understand so I was not able to clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only had one callsite which was easily simplified.
Uplifted a comment that I think is much more useful living in
ty::Constworld.